Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gRPC client provider for cross service and external calls #173

Merged
merged 5 commits into from
Jan 27, 2025
Merged

feat: gRPC client provider for cross service and external calls #173

merged 5 commits into from
Jan 27, 2025

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Jan 24, 2025 •
edited
Loading

@github-actions github-actions bot added documentation documentation related java-sdk labels Jan 24, 2025
@johanandren johanandren marked this pull request as ready for review January 27, 2025 13:52
@johanandren
Copy link
Member Author

I think we could merge this and I'll continue with limiting config and potentially allowing service name config override in test/dev

efgpinto
efgpinto approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@efgpinto efgpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit 739b9a5 into grpc-endpoints Jan 27, 2025
24 checks passed
@johanandren johanandren deleted the wip-grpc-clients branch January 27, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efgpinto efgpinto efgpinto approved these changes

Assignees
No one assigned
Labels
documentation documentation related java-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanandren @efgpinto