feat: Http endpoint base class with request context access #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # akka-javasdk/src/main/java/akka/javasdk/http/RequestContext.java # akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala
johanandren
force-pushed
the
wip-optional-endpoint-baseclass
branch
from
0f6b24f to
06cda58
Compare
octonato
reviewed
Nov 21, 2024
| /** | ||
| * Optional base class for HTTP endpoints giving access to a request context without additional constructor parameters | ||
| */ | ||
| abstract public class AbstractHttpEndpoint { |
There was a problem hiding this comment.
Alternatively, we could call it RequestContextSupport.
And maybe better if we make this a interface with default methods. As such users can use it as a mixin instead.
And have some other base classes on their own.
There was a problem hiding this comment.
We need a field so interface does not work.
johanandren
added a commit
that referenced
this pull request
Nov 21, 2024
* feat: Http endpoint base class with request context access # Conflicts: # akka-javasdk/src/main/java/akka/javasdk/http/RequestContext.java # akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala * post rebase fixes * formatting...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only showcased on ACL and JWT doc pages so far, once we add header support, it will go on the HTTP endpoint page as well.