Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Actually specify an exception handler or gRPC endpoints #196

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: Actually specify an exception handler or gRPC endpoints #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions akka-javasdk/src/main/scala/akka/javasdk/impl/GrpcEndpointDescriptorFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package akka.javasdk.impl

import akka.actor.typed.ActorSystem
import akka.grpc.ServiceDescription
import akka.grpc.scaladsl.GrpcExceptionHandler
import akka.grpc.scaladsl.InstancePerRequestFactory
import akka.http.scaladsl.model.HttpRequest
import akka.http.scaladsl.model.HttpResponse
Expand Down Expand Up @@ -57,8 +58,8 @@ object GrpcEndpointDescriptorFactory {
handlerFactory.partialInstancePerRequest(
serviceFactory,
description.name,
// FIXME default error handler, is it fine to leave like this, should runtime define?
PartialFunction.empty,
// FIXME would be better if this was up to the runtime
GrpcExceptionHandler.defaultMapper(system.classicSystem),
system)
}

Expand Down
Loading