feat: kip447 transactions #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -Werror by default
ennru
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Let's see if I get this correctly:
- The source/flow auto-generates the
transactionalId - When consuming, the
TransactionalMessageBuilderinjectsConsumerGroupMetadatawith the offset - That metadata is used in
TransactionalProducerStage.commitTransaction - Safeguards avoid pre-emptive stage shutdown
Other changes improve thread safety and make use of improved stuff in Scala and Akka.
LGTM.
core/src/main/scala/akka/kafka/internal/TransactionalSources.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/kafka/internal/TransactionalSources.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/kafka/internal/TransactionalSources.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/kafka/internal/TransactionalProducerStage.scala
Show resolved
Hide resolved
core/src/main/scala/akka/kafka/internal/TransactionalProducerStage.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com>
|
Pretty much, small correction:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new APIs added for KIP447 to pass the right consumer group metadata along when committing the transaction. This should avoid the need to use any specific scheme for the transaction id other than making sure it is unique per consumer-producer stream (so could be a UUID for example)