Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove javac options that confuse javadoc #528

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Remove javac options that confuse javadoc #528

merged 2 commits into from
Oct 17, 2017

Conversation

raboof
Copy link
Member

@raboof raboof commented Oct 16, 2017

The javadoc tool returned an error (and failed the build) for me because of the
-Xlint:unchecked option which is passed to javadoc but not
recognized there.

The javadoc tool returned an error (and failed the build) for me because of the
-Xlint:unchecked option which is passed to javadoc but not
recognized there.
@2m
Copy link
Member

2m commented Oct 16, 2017

Which command failed for you? AFAICS unidoc does not generate Javadoc in Alpakka.

@raboof
Copy link
Member Author

raboof commented Oct 16, 2017

sbt package is fine, but sbt publishLocal gives the error for me

@2m
Copy link
Member

2m commented Oct 16, 2017

This is interesting. Since the spring-web alpakka module has only Java code, the spring-web/compile:doc task starts javadoc (in contrast this task for all other projects starts scaladoc).

The proper fix would be to scope the javacOptions to compile task, so it is not picked up by the doc task:

diff --git a/project/Common.scala b/project/Common.scala
index bcb767c..8e74141 100644
--- a/project/Common.scala
+++ b/project/Common.scala
@@ -40,7 +40,7 @@ object Common extends AutoPlugin {
       "-Ywarn-dead-code",
       "-Xfuture"
     ),
-    javacOptions ++= Seq(
+    javacOptions in compile ++= Seq(
       "-Xlint:unchecked"
     ),
     autoAPIMappings := true,

@2m
Copy link
Member

2m commented Oct 17, 2017

Nice. Validation issue was #527

@2m 2m merged commit a3afb57 into master Oct 17, 2017
@2m 2m deleted the springWebJavadocError branch October 17, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants