Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an example project Akka.Hosting.CustomJournalIdDemo.FSharp #183

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

ingted
Copy link
Contributor

@ingted ingted commented Jan 5, 2023

Fixes #

With F# class explicit interface implemented situation, (This is part of the Akka.Hosting demo project, and I port it into F#)

    [<Interface>] 
    type IWithUserId =
        abstract member UserId : string

    type UserDescriptor(UserId:string, UserName:string) =
        interface IWithUserId with
            member this.UserId = this.UserId //line1
        member this.UserId = UserId  //line2
    
        member this.UserName = UserName

If I don't add line2, then UserId of the deserialized object will be null...

Changes

Added an example project Akka.Hosting.CustomJournalIdDemo.FSharp. And bug fixed.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

Include data from the relevant benchmark prior to this change here.

This PR's Benchmarks

Include data from after this change here.

@ingted
Copy link
Contributor Author

ingted commented Jan 5, 2023

image
I didn't change build.cmd... Don't know why it failed ...

@Aaronontheweb
Copy link
Member

@ingted we'll see what GitHub Actions reports back on the PR and maybe I can help troubleshoot

@Aaronontheweb
Copy link
Member

LGTM!

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) January 5, 2023 17:54
@Aaronontheweb Aaronontheweb merged commit e797852 into akkadotnet:dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants