Add SSL support for Remote.Hosting #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in that case, might be better off not doing this until we actually need additional transports. |
|
Updated the PR comment to explain why configuration binding doesn't work |
Aaronontheweb
requested changes
Aug 1, 2023
| public override string TransportId { get; } | ||
| protected override void Build(System.Text.StringBuilder builder) { } | ||
| } | ||
| public sealed class DotNettyUdpTransportOptions : Akka.Remote.Hosting.DotNettyTransportOptions |
There was a problem hiding this comment.
Remove - not supported in Akka.Remote and most likely won't be.
| { | ||
| public RemoteOptions() { } | ||
| public System.Collections.Generic.List<Akka.Remote.Hosting.RemoteTransportOptions> EnabledTransports { get; set; } |
There was a problem hiding this comment.
You know, I'm thinking that even though we could support this - it's probably a footgun for 99.9999999999999% of users. Make super-users use HOCON if they want this feature.
| public abstract string TransportId { get; } | ||
| protected abstract void Build(System.Text.StringBuilder builder); | ||
| } | ||
| public sealed class SslCertificateOptions |
|
Remove multi-transport support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
Changes