Automatically add default Akka.Streams HOCON #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in response to a customer issue where the following happened: 1. Using `StreamRef`s 2. Transmits a `StreamRef` to a node that has never called any materialization functions 3. Serialization error due to missing serializer definitions. In normal Akka.NET you'd have to fix this by manually appending `ActorMaterializer.DefaultConfig()` as a fallback. In Akka.Hosting we can just do this automatically at startup.
Aaronontheweb
commented
Aug 29, 2024
There was a problem hiding this comment.
Just some C# modernization
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Akka.DependencyInjection" Version="$(AkkaVersion)" /> | |||
| <PackageReference Include="Akka.Streams" Version="$(AkkaVersion)" /> | |||
There was a problem hiding this comment.
We need to move this project to centralized package management
| // add the default Akka.Streams configuration by default - hurts nothing, but | ||
| // ensures that StreamRefs work correctly out of the box in case users | ||
| // haven't attempted to materialize a stream yet | ||
| b.AddHocon(ActorMaterializer.DefaultConfig(), HoconAddMode.Append); |
There was a problem hiding this comment.
Added the HOCON here - it can be in Append mode because it's just the defaults - it can go at the end of the line.
There was a problem hiding this comment.
More C# modernization.
Arkatufus
added a commit
to Arkatufus/Akka.Hosting
that referenced
this pull request
Sep 4, 2024
This reverts commit d7cf636.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is in response to a customer issue where the following happened:
StreamRefsStreamRefto a node that has never called any materialization functionsIn normal Akka.NET you'd have to fix this by manually appending
ActorMaterializer.DefaultConfig()as a fallback. In Akka.Hosting we can just do this automatically at startup.I added a reference to Akka.Streams in the default Akka.Hosting module. There's not a lot of value in making a custom Akka.Streams.Hosting package as "add this config" is the only method that would be in it. If there's a good reason why we shouldn't add it to the default Akka.Hosting package, please say so in a review.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):