Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding v1.3.14-style serialization #71

Merged
merged 18 commits into from
Oct 30, 2019

Conversation

Aaronontheweb
Copy link
Member

No description provided.

@Aaronontheweb
Copy link
Member Author

Disabled the serialization implementation, but added the serialization spec.

Bad news is: Akka.Persistence.MongoDb doesn't pass any of the Akka.Persistence.TCK requirements using either binary or object storage, and it's unlikely that it will without some major and possibly breaking changes.

@Aaronontheweb
Copy link
Member Author

Binary serialization for MongoDbSnapshotStore should now pass.

@Aaronontheweb
Copy link
Member Author

Need to handle better serialization support for Tagged - causing a few specs to fail at the moment

@Aaronontheweb
Copy link
Member Author

Last change cut the number of failed tests down from 11 to 4 - getting there

@Aaronontheweb
Copy link
Member Author

All tests should now pass, except for the ones covered by this change: akkadotnet/akka.net#4002

@Aaronontheweb
Copy link
Member Author

Validated that data saved via Akka.Persistence.MongoDb v1.3.12 can be recovered with the new serialization code, when saved as objects. Going to try testing it with binary serialization next.

@Aaronontheweb
Copy link
Member Author

Looks good using binary serialization as well, using snapshots and event journal. I think this change should be ok for v1.4.0 with some further testing in the field.

@Aaronontheweb Aaronontheweb marked this pull request as ready for review October 30, 2019 19:55
@Aaronontheweb
Copy link
Member Author

Merging this in. The same usual suspects tests will fail until I pull in the v1.4.0 bits, which I am doing next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant