Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journal and snapshot store should obtain their configuration from Persistence #147

Merged

Conversation

Arkatufus
Copy link
Contributor

Closes #16

Arkatufus added 3 commits May 11, 2021 23:47
…istence instead of using default all the time
…_from_Persistence

# Conflicts:
#	src/Akka.Persistence.Redis/Journal/RedisJournal.cs
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test to:

  1. Validate
  2. Guard against future regressions?

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) May 12, 2021 22:07
@Aaronontheweb Aaronontheweb merged commit 2d8d47c into akkadotnet:dev May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Use Multiple Named Redis journal/snapshot-store Configurations
2 participants