Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change common.props to Build Directory File and migrate to central package management #276

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Change common.props to Build Directory File and migrate to central package management #276

merged 6 commits into from
Sep 22, 2023

Conversation

mhbuck
Copy link
Contributor

@mhbuck mhbuck commented Aug 21, 2023 •
edited
Loading

Changes

Move to using directory props file and central package management
Similar to what was done in akkadotnet/Akka.Persistence.MongoDB#333

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

mhbuck
mhbuck commented Aug 21, 2023
View reviewed changes
src/Directory.Build.props
@@ -48,16 +48,16 @@ Other Changes**
<AkkaVersion>1.5.8</AkkaVersion>
<RedisVersion>2.6.111</RedisVersion>
<DockerVersion>3.125.15</DockerVersion>
<NetCoreTestVersion>netcoreapp3.1</NetCoreTestVersion>
<NetTestVersion>net7.0</NetTestVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sense check here - Instead of maintaining testing against netcoreapp 3.1 I changed it to just using net7 and renamed the property. This is more inline with what is done on the main Akka project

src/Directory.Build.props
<NetStandardVersion>netstandard2.0</NetStandardVersion>
<NetFrameworkTestVersion>net461</NetFrameworkTestVersion>
<NetFrameworkTestVersion>net471</NetFrameworkTestVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also upgraded framework target to match the main project - Not sure if there are any implications.

@mhbuck
Copy link
Contributor Author

mhbuck commented Aug 21, 2023

Locally all tests are passing - Not sure what happened for the test Akka.Persistence.Redis.Cluster.Tests.RedisJournalDefaultDatabaseSpec.Randomly_distributed_RedisKey_with_HashTag_should_be_distributed_relatively_equally_between_cluster_master

mhbuck
mhbuck commented Sep 21, 2023
View reviewed changes
build.fsx
(sprintf "nuget push %s --api-key %s --source %s" project apiKey source)

projects |> Seq.iter (runSingleProject)
let shouldPushNugetPackages = hasBuildParam "nugetkey"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matching the changes made in akkadotnet/Akka.Persistence.MongoDB#357

There was nothing specific to the mongo repo that I could find.

src/Directory.Build.props
@@ -41,23 +42,24 @@ Other Changes**
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Description>Akka.NET Persistence journal and snapshot store backed by Redis.</Description>
<NoWarn>$(NoWarn);CS1591</NoWarn>
<LangVersion>latest</LangVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed to the latest language version

src/Directory.Build.props Outdated
@@ -5,6 +5,7 @@
<VersionPrefix>1.4.16</VersionPrefix>
<PackageTags>akka;actors;actor model;Akka;concurrency;persistence;eventsource;redis</PackageTags>
<PackageIconUrl>http://getakka.net/images/AkkaNetLogo.Normal.png</PackageIconUrl>
<PackageReadmeFile>README.md</PackageReadmeFile>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md is included in the package in line 63 of this file so it could be referenced.

I noticed that in the MultNodeTestRunner changes were done for the Icon. Is that something that should be done for this repo as well? It current references the icon from the getakka site (Line 7 of this file)
https://github.com/akkadotnet/Akka.MultiNodeTestRunner/pull/201/files#diff-5c1900dca99df01c3ddc3a884282164b04deee76e79b176e2d34cfa47f3b8907R23

@Arkatufus
Copy link
Contributor

Tested using local BaGet installation:

Starting Target: PublishNuget (==> SignPackages)
Pushing nuget packages
Pushing D:\git\akkadotnet\akka.persistence.redis\bin\nuget\Akka.Persistence.Redis.1.5.0.nupkg Attempts left: 3
Pushing Akka.Persistence.Redis.1.5.0.nupkg to 'https://localhost:5001/api/v2/package'...
  PUT https://localhost:5001/api/v2/package/
  Created https://localhost:5001/api/v2/package/ 32ms
Your package was pushed.
Pushing Akka.Persistence.Redis.1.5.0.snupkg to 'https://localhost:5001/api/v2/symbol'...
  PUT https://localhost:5001/api/v2/symbol/
  Created https://localhost:5001/api/v2/symbol/ 12ms
Your package was pushed.
Finished Target: PublishNuget

Arkatufus
Arkatufus approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) September 22, 2023 14:48
@Arkatufus Arkatufus merged commit 389d3e2 into akkadotnet:dev Sep 22, 2023
@mhbuck mhbuck deleted the buildupgrade branch September 22, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkatufus Arkatufus Arkatufus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhbuck @Arkatufus