Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Akka to 1.4.4 #42

Merged
merged 21 commits into from
Apr 10, 2020

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Mar 3, 2020

  • Update to Akka 1.4.1-RC1 1.4.4
  • Use common.props instead of relying on hard coded version numbers.
  • Implement Docker.DotNet to deploy Docker container for unit test validation.

@Arkatufus
Copy link
Contributor Author

Arkatufus commented Mar 4, 2020

  • Windows Redis is installed manually inside the windows build script.
  • One test failing consistently. Need clarification:
    When a journal entry with an event adapter that modifies its manifest is stored, will the stored journal manifest be equal to the original journal manifest? If not, then the unit test is broken.

@Arkatufus
Copy link
Contributor Author

@Arkatufus Arkatufus changed the title Update Akka to 1.4.1-RC1 Update Akka to 1.4.4 Apr 10, 2020
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but we need to roll back the changes to the build system. The current one is fine.

<configuration>
<packageSources>
<clear />
<add key="nuget.org" value="https://www.nuget.org/api/v2/" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this - don't need it anymore.

@@ -1,14 +1,12 @@
parameters:
name: ''
displayName: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roll back these changes - the current build files are fine and are in-use.

@@ -0,0 +1,22 @@
# Pull request validation for Linux against the `dev` and `master` branches
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roll back these changes - the current build files are fine and are in-use.

@@ -14,17 +14,9 @@ pr:
name: $(Year:yyyy).$(Month).$(DayOfMonth)$(Rev:.r)

jobs:
- template: azure-pipeline.template.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roll back these changes - the current build files are fine and are in-use.

- name: projectName
value: yourProjectName #replace this
value: Akka.Persistence.SqlServer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change this to Akka.Persistence.Redis

build.ps1 Outdated
###########################################################################
# INSTALL REDIS
###########################################################################
$RedisExePath = Join-Path $ToolPath "redis-64/tools/redis-server.exe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need this if we're using Docker.NET

{
}

public class RedisFixture : IAsyncLifetime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb
Copy link
Member

@Arkatufus maybe we should run this on Linux only

@Arkatufus
Copy link
Contributor Author

Arkatufus commented Apr 10, 2020

@Arkatufus maybe we should run this on Linux only

Agreed, this is very very annoying.

@Aaronontheweb Aaronontheweb merged commit fb7a8b8 into akkadotnet:dev Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants