-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Akka to 1.4.4 #42
Update Akka to 1.4.4 #42
Conversation
# Conflicts: # NuGet.Config # src/common.props
|
The code in question is this line: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but we need to roll back the changes to the build system. The current one is fine.
<configuration> | ||
<packageSources> | ||
<clear /> | ||
<add key="nuget.org" value="https://www.nuget.org/api/v2/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this - don't need it anymore.
@@ -1,14 +1,12 @@ | |||
parameters: | |||
name: '' | |||
displayName: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roll back these changes - the current build files are fine and are in-use.
@@ -0,0 +1,22 @@ | |||
# Pull request validation for Linux against the `dev` and `master` branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roll back these changes - the current build files are fine and are in-use.
@@ -14,17 +14,9 @@ pr: | |||
name: $(Year:yyyy).$(Month).$(DayOfMonth)$(Rev:.r) | |||
|
|||
jobs: | |||
- template: azure-pipeline.template.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roll back these changes - the current build files are fine and are in-use.
build-system/windows-release.yaml
Outdated
- name: projectName | ||
value: yourProjectName #replace this | ||
value: Akka.Persistence.SqlServer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change this to Akka.Persistence.Redis
build.ps1
Outdated
########################################################################### | ||
# INSTALL REDIS | ||
########################################################################### | ||
$RedisExePath = Join-Path $ToolPath "redis-64/tools/redis-server.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't need this if we're using Docker.NET
{ | ||
} | ||
|
||
public class RedisFixture : IAsyncLifetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Arkatufus maybe we should run this on Linux only |
Agreed, this is very very annoying. |
1.4.1-RC11.4.4common.props
instead of relying on hard coded version numbers.