Migrate build system to net8 / fake v6 #361

anpin · 2024-04-17T18:53:31Z

This PR updates build scripts to FAKE v6 and updates test targets to net8.0 thus reducing the need for developer to have multiple ~~outdated~~ build tools to get started.

Fixes
#360
#362

Changes

Updated FAKE from v4 to v6 and removed old bootstrap scripts
NetCoreTestVersion updated to net8.0 (which required MySql.Data to be updated to latest version)
DocFx updated to latest version which uses dotnet-tools (allows working with docs on mac/linux)
DocFx serve is invoked as a part of build.fsx and serve-docs.[cmd|sh] are updated to use that
Fixed broken links in docs
Refactored docker container initialization to fix inconsistent test runs
Adds benchmarks to the build script

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

This change follows the Akka.NET API Compatibility Guidelines.
This change follows the Akka.NET Wire Compatibility Guidelines.
I have reviewed my own pull request.
Design discussion issue #
Changes in public API reviewed, if any.
I have added website documentation for this feature.

Latest `dev` Benchmarks

Include data from the relevant benchmark prior to this change here.

This PR's Benchmarks

Include data from after this change here.

anpin · 2024-04-17T18:54:54Z

currently runs locally on linux, windows not tested yet. Plus there are some errors in the tests themselves, probably due to mismatched dependencies.

anpin · 2024-04-18T14:01:18Z

tests seem to be rather flaky both on my machine and in CI. containers sometimes fail on startup.

Aaronontheweb · 2024-04-18T20:19:58Z

@anpin we definitely have some flaky tests - I'll try to take a look at this. Thank you for your hard work

anpin · 2024-04-18T21:52:34Z

@Aaronontheweb my apologies for not discussing this major change upfront, but I need to build the package from source and didn't want to use some temporary scripts

anpin · 2024-04-18T22:18:15Z

regarding failing tests #362

- previous GetContainerLogsAsync method returning stream was marked obsolete, so I replaced it with the IProgress based version - Added retry loop in case container fails to start (e.g. port is alraedy in use)

anpin · 2024-04-19T12:32:58Z

Let's see if tests would run consistently in CI now. On my machine they do not fail randomly with last commit.

anpin · 2024-04-19T14:57:06Z

updating release notes just to trigger the build again and see if any error would occur

anpin · 2024-04-19T16:23:44Z

seems to be working. @Aaronontheweb please let me know if anything else is required to merge this

Aaronontheweb

LGTM - nice work. Would love it if we could bring some of this stuff to the main Akka.NET project too (it also uses an aging FAKE system)

Aaronontheweb · 2024-04-19T16:56:47Z

.config/dotnet-tools.json

@@ -7,6 +7,12 @@
      "commands": [
        "jb"
      ]
+    },
+    "docfx": {


WE can probably get rid of DocFx altogether (it was just part of the template for this repo) but I appreciate you doing this

Will probably make CI faster. I figured it could be executed from some over place where the documentation is built, so I tried to keep it comparability reasons

Aaronontheweb · 2024-04-19T16:57:04Z

build-system/azure-pipeline.template.yaml

Aaronontheweb · 2024-04-19T16:57:10Z

build-system/windows-release.yaml

Aaronontheweb · 2024-04-19T16:57:42Z

build.fsx

Aaronontheweb · 2024-04-19T16:57:57Z

build.sh

LGTM - much better lol

Aaronontheweb · 2024-04-19T16:58:33Z

docs/docfx.json

@@ -62,7 +62,7 @@
            ]
        }],
        "xref": [
-            "../tools/msdn.4.5.2/content/msdn.4.5.2.zip"
+            "https://learn.microsoft.com/en-us/dotnet/.xrefmap.json"


We should do this in the main Akka.NET repo as well - uses the same system (I would love to get off of the old FAKE there too)

Aaronontheweb · 2024-04-19T16:59:00Z

src/Akka.Persistence.Sql.Data.Compatibility.Tests/Internal/DockerContainer.cs

Aaronontheweb · 2024-04-19T17:00:51Z

lol this reminds me, I need to finish getting akkadotnet/akka.net#7063 merged in

anpin · 2024-04-19T19:12:11Z

LGTM - nice work. Would love it if we could bring some of this stuff to the main Akka.NET project too (it also uses an aging FAKE system)

Thanks. I can probable take a look at the main repo too.

anpin changed the title ~~migrate build system to net8 / fake v6~~ [WIP] migrate build system to net8 / fake v6 Apr 17, 2024

anpin force-pushed the feature/net8 branch 2 times, most recently from 3957af5 to 7edda72 Compare April 17, 2024 22:24

anpin mentioned this pull request Apr 17, 2024

Update MSBuild.StructuredLogger to latest fsprojects/FAKE#2744

Open

anpin force-pushed the feature/net8 branch 4 times, most recently from dd312c4 to 94922c3 Compare April 18, 2024 12:16

anpin force-pushed the feature/net8 branch 2 times, most recently from 2c70a81 to 53e1052 Compare April 18, 2024 15:25

migrate build system to net8 / fake v6

3f84d2a

anpin force-pushed the feature/net8 branch from 53e1052 to 3f84d2a Compare April 18, 2024 15:26

anpin changed the title ~~[WIP] migrate build system to net8 / fake v6~~ Migrate build system to net8 / fake v6 Apr 18, 2024

anpin marked this pull request as ready for review April 18, 2024 16:18

run benchmarks from build script

9cbeada

don't run benchmarks on windows

3bb5d50

anpin force-pushed the feature/net8 branch from 4f1b29e to 3bb5d50 Compare April 18, 2024 21:57

anpin added 2 commits April 18, 2024 23:38

fix execution order

9e56fb6

increase timeout for benchmarks

18783a0

anpin force-pushed the feature/net8 branch from 481f9e0 to 18783a0 Compare April 18, 2024 22:38

refactored docker container initialization

f1856be

- previous GetContainerLogsAsync method returning stream was marked obsolete, so I replaced it with the IProgress based version - Added retry loop in case container fails to start (e.g. port is alraedy in use)

update release notes

cb5ff39

Aaronontheweb approved these changes Apr 19, 2024

View reviewed changes

Aaronontheweb merged commit 48aa3a8 into akkadotnet:dev Apr 19, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate build system to net8 / fake v6 #361

Migrate build system to net8 / fake v6 #361

anpin commented Apr 17, 2024 •

edited

Loading

anpin commented Apr 17, 2024 •

edited

Loading

anpin commented Apr 18, 2024

Aaronontheweb commented Apr 18, 2024

anpin commented Apr 18, 2024

anpin commented Apr 18, 2024 •

edited

Loading

anpin commented Apr 19, 2024

anpin commented Apr 19, 2024

anpin commented Apr 19, 2024

Aaronontheweb left a comment

Aaronontheweb Apr 19, 2024

anpin Apr 19, 2024

Aaronontheweb Apr 19, 2024

Aaronontheweb Apr 19, 2024

Aaronontheweb Apr 19, 2024

Aaronontheweb Apr 19, 2024

Aaronontheweb Apr 19, 2024

Aaronontheweb Apr 19, 2024

Aaronontheweb commented Apr 19, 2024

anpin commented Apr 19, 2024

Migrate build system to net8 / fake v6 #361

Migrate build system to net8 / fake v6 #361

Conversation

anpin commented Apr 17, 2024 • edited Loading

Changes

Checklist

Latest dev Benchmarks

This PR's Benchmarks

anpin commented Apr 17, 2024 • edited Loading

anpin commented Apr 18, 2024

Aaronontheweb commented Apr 18, 2024

anpin commented Apr 18, 2024

anpin commented Apr 18, 2024 • edited Loading

anpin commented Apr 19, 2024

anpin commented Apr 19, 2024

anpin commented Apr 19, 2024

Aaronontheweb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aaronontheweb commented Apr 19, 2024

anpin commented Apr 19, 2024

anpin commented Apr 17, 2024 •

edited

Loading

Latest `dev` Benchmarks

anpin commented Apr 17, 2024 •

edited

Loading

anpin commented Apr 18, 2024 •

edited

Loading