Use the configuration with fallback for snapshot store #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@izavala looks like we're going to need to get this project migrated onto Azure pipelines as well then, since TeamCity is currently offline. |
|
@lesscodetxm ok, build system is back up and running properly again - going to re-run these tests. |
Aaronontheweb
approved these changes
Jun 21, 2019
| @@ -28,7 +28,7 @@ public SqlServerSnapshotStore(Config config) : base(config) | |||
| manifestColumnName: "Manifest", | |||
| timestampColumnName: "Timestamp", | |||
| serializerIdColumnName: "SerializerId", | |||
| timeout: sqlConfig.GetTimeSpan("connection-timeout"), | |||
| timeout: config.GetTimeSpan("connection-timeout"), | |||
There was a problem hiding this comment.
I see the real issue was this line:
snapshotTableName: config.GetString("table-name"),
Before your change, config never had the fallback itself - that was applied, immutably, afterwards. This makes sense now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.