Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernizing build system to support Akka.NET v1.4.0 #115

Merged
merged 15 commits into from
Jun 21, 2019

Conversation

Aaronontheweb
Copy link
Member

Work in progress - the build system on this project is pretty old and out of date compared to all of the other regularly developed Akka.NET plugins. Needs to be modernized in order to support the new changes coming out in Akka.NET v1.4.0.

@Aaronontheweb
Copy link
Member Author

Going to use this to help test akkadotnet/akka.net#3744 in a real environment for backwards-compatibility purposes.

@Aaronontheweb Aaronontheweb marked this pull request as ready for review June 19, 2019 14:44
@Aaronontheweb
Copy link
Member Author

This is ready to go, but is failing because:

  1. Windows - appears to be either a config or a timing issue connecting to the container. Working on reproducing this locally.
  2. Linux - a very weird compilation issue that looks like the result of two different versions of the same System.Runtime dependency being pulled in.

@Aaronontheweb
Copy link
Member Author

Looks like, on Docker for Windows, changing the SA credentials is what killed it

@Aaronontheweb
Copy link
Member Author

Fixed the issue with Windows containers using the work-around I documented here dotnet/Docker.DotNet#402

@Aaronontheweb Aaronontheweb merged commit c5dbf60 into akkadotnet:dev Jun 21, 2019
@Aaronontheweb Aaronontheweb deleted the v1.4.0-ready-build-system branch June 21, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant