-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernizing build system to support Akka.NET v1.4.0 #115
Merged
Aaronontheweb
merged 15 commits into
akkadotnet:dev
from
Aaronontheweb:v1.4.0-ready-build-system
Jun 21, 2019
Merged
modernizing build system to support Akka.NET v1.4.0 #115
Aaronontheweb
merged 15 commits into
akkadotnet:dev
from
Aaronontheweb:v1.4.0-ready-build-system
Jun 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to use this to help test akkadotnet/akka.net#3744 in a real environment for backwards-compatibility purposes. |
This is ready to go, but is failing because:
|
Looks like, on Docker for Windows, changing the SA credentials is what killed it |
Fixed the issue with Windows containers using the work-around I documented here dotnet/Docker.DotNet#402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress - the build system on this project is pretty old and out of date compared to all of the other regularly developed Akka.NET plugins. Needs to be modernized in order to support the new changes coming out in Akka.NET v1.4.0.