Implement SQL query transaction isolation level from Akka.NET 1.5.3 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Apr 21, 2023
| using (var conn = new SqlConnection(ConnectionString)) | ||
| var oldDatabaseName = _builder.InitialCatalog; | ||
| var databaseName = $"akka_persistence_tests_{Guid.NewGuid()}"; | ||
| _builder.InitialCatalog = databaseName; |
There was a problem hiding this comment.
Create a new database for each unit tests to prevent cross-polination between unit tests
Arkatufus
commented
Apr 21, 2023
| Context.System.Serialization, | ||
| GetTimestampProvider(config.GetString("timestamp-provider"))); | ||
| } | ||
|
|
||
| [InternalApi] | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| internal static QueryConfiguration CreateQueryConfiguration(Config config, JournalSettings settings) |
There was a problem hiding this comment.
Move out QueryConfiguration creation so that is testable
Arkatufus
commented
Apr 21, 2023
| Context.System.Serialization); | ||
| } | ||
|
|
||
| [InternalApi] | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| internal static QueryConfiguration CreateQueryConfiguration(Config config, SnapshotStoreSettings settings) |
There was a problem hiding this comment.
Move out QueryConfiguration creation so that it is testable
Arkatufus
commented
Apr 21, 2023
| defaultSerializer: config.GetString("serializer"), | ||
| useSequentialAccess: config.GetBoolean("sequential-access"), | ||
| readIsolationLevel: settings.ReadIsolationLevel, | ||
| writeIsolationLevel: settings.WriteIsolationLevel); |
There was a problem hiding this comment.
Pass in new isolation level arguments
Arkatufus
commented
Apr 21, 2023
| defaultSerializer: config.GetString("serializer"), | ||
| useSequentialAccess: config.GetBoolean("sequential-access"), | ||
| readIsolationLevel: settings.ReadIsolationLevel, | ||
| writeIsolationLevel: settings.WriteIsolationLevel); |
There was a problem hiding this comment.
Pass in new isolation level arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IsolationLevelin settings