Fix bugged Dependabot version update for XUnit #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jan 10, 2024
| @@ -10,7 +10,7 @@ | |||
| <PackageReference Include="FluentAssertions" Version="$(FluentAssertionsVersion)" /> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(TestSdkVersion)" /> | |||
| <PackageReference Include="xunit" Version="$(XunitVersion)" /> | |||
| <PackageReference Include="xunit.runner.visualstudio" Version="$(XunitVersion)" /> | |||
There was a problem hiding this comment.
I suspect that dependabot analyzer got confused because of this line and applied the version upgrade to both XunitRunnerVersion and XunitVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1775
Changes
In #1775, Dependabot was confused between
XunitVersionandXunitRunnerVersionand applied a version upgrade for the xunit runner to both XML parameters. There are no XUnit version 2.5.6, moving it to 2.5.3 to match the version that is used in Akka.NET core.