added publisher confirms functionality to RabbitMQ #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Mar 27, 2024
There was a problem hiding this comment.
End to end spec using AmpqSink and AmpqFlow with publisher confirmations enabled
| @@ -12,11 +13,11 @@ namespace Akka.Streams.Amqp.RabbitMq | |||
| public class AmqpFlowStage<TPassThrough> : GraphStageWithMaterializedValue<FlowShape<(OutgoingMessage, TPassThrough), TPassThrough>, Task> | |||
| { | |||
| public static readonly Attributes DefaultAttributes = | |||
| Attributes.CreateName("AmqpFlow").And(ActorAttributes.CreateDispatcher("akka.stream.default-blocking-io-dispatcher")); | |||
There was a problem hiding this comment.
No need to run on the blocking I/O dispatcher
| @@ -59,6 +60,13 @@ public Logic(AmqpFlowStage<TPassThrough> stage, TaskCompletionSource<Done> promi | |||
| elem.Mandatory, | |||
| elem.Properties, | |||
| elem.Bytes.ToArray()); | |||
|
|
|||
| if(_stage.Settings.WaitForConfirms) | |||
There was a problem hiding this comment.
Upon publish, wait for confirms before we push downstream.
| if (_stage.Settings.WaitForConfirms) | ||
| { | ||
| // enable publisher confirms | ||
| Channel.ConfirmSelect(); |
There was a problem hiding this comment.
Need this in order to enable publisher confirmations on the channel
| @@ -56,6 +58,14 @@ public AmqpSinkStageLogic(AmqpSinkStage stage, TaskCompletionSource<Done> promis | |||
| elem.Mandatory, | |||
| elem.Properties, | |||
| elem.Bytes.ToArray()); | |||
|
|
|||
| if(_stage.Settings.WaitForConfirms) | |||
There was a problem hiding this comment.
Mirrors what we did in the flow
| if (_stage.Settings.WaitForConfirms) | ||
| { | ||
| // enable publisher confirms | ||
| Channel.ConfirmSelect(); |
There was a problem hiding this comment.
Mirrors what we did in the flow
| /// </remarks> | ||
| public bool WaitForConfirms => WaitForConfirmsTimeout is not null; | ||
|
|
||
| public TimeSpan? WaitForConfirmsTimeout { get; } |
There was a problem hiding this comment.
Settings - when this gets set to a non-null value that will enabled publisher confirms using the specified timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implements https://www.rabbitmq.com/docs/confirms#publisher-confirms functionality to
AmqpSinkandAmqpFlowstages, for an extra dose of guaranteed reliability.Checklist