Hocon improvement. #218
Merged
Hocon improvement. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GetString(), GetStringList(), GetInt(), and GetDouble() throws on failure instead of returning a default value (Major change in Akka.NET). - Add TryGet[DataType]() functions to all getters to eliminate as much Exception throwing as possible to improve performance. - Remove as much wrapping functions as possible to improve performance. - Fix Config.Equal infinite loop bug.
Love that idea. |
…iled to merge the fallbacks correctly.
Aaronontheweb
approved these changes
Feb 12, 2020
| ReferenceEquals(oldA, a).Should().BeTrue(); | ||
| oldAContent.Should().Equals(a); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void WithFallback_ShouldMergeSubstitutionProperly() |
There was a problem hiding this comment.
Ah, this is the reproduction case you were talking about. Good, glad we have it.
| public Config Config { | ||
| get | ||
| { | ||
| if (_config == null && !string.IsNullOrWhiteSpace(Hocon.Content)) |
| @@ -54,22 +54,38 @@ public HoconRoot(HoconValue value, IEnumerable<HoconSubstitution> substitutions) | |||
| /// </summary> | |||
| public IEnumerable<HoconSubstitution> Substitutions { get; private set; } | |||
|
|
|||
| protected virtual HoconValue GetNode(HoconPath path, bool throwIfNotFound = false) | |||
| protected virtual bool TryGetNode(string path, out HoconValue result) | |||
| { | ||
| return WrapWithValueException(path.ToString(), () => |
There was a problem hiding this comment.
These designs, using the Try methods instead of WrapWithValueException, are a major improvement.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still related to akkadotnet/akka.net#4128
IEquitable<Config>interface implementation toConfigclassGetString(),GetStringList(),GetInt(), andGetDouble()throws on failure instead of returning a default value (Major change in Akka.NET).TryGet[DataType]()functions to all getters to eliminate as much Exception throwing as possible to improve performance.