Fix AK1001 code fix for lambda expression with no block body #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jan 17, 2024
Comment on lines
-63
to
-72
| // Find an appropriate insertion point for the local variable | ||
| var insertionPoint = invocationExpr.FirstAncestorOrSelf<StatementSyntax>(); | ||
|
|
||
| if (insertionPoint == null) | ||
| // Unable to find a valid insertion point | ||
| return document; | ||
|
|
||
| // Insert the local variable declaration at the found insertion point | ||
| editor.InsertBefore(insertionPoint, senderVariable); | ||
|
|
There was a problem hiding this comment.
Need to reshuffle this code to the end
Comment on lines
+90
to
+103
| // Make sure to replace the old invocation with the new one | ||
| var newExprSyntax = exprSyntax.ReplaceNode(invocationExpr, newInvocationExpr); | ||
|
|
||
| // Create a new block with the original lambda body as a statement | ||
| var originalBody = SyntaxFactory.ExpressionStatement(newExprSyntax); | ||
|
|
||
| // Insert the local variable declaration at the start of the lambda block | ||
| var bodyBlock = SyntaxFactory.Block( | ||
| senderVariable.WithTrailingTrivia(SyntaxFactory.ElasticCarriageReturnLineFeed), | ||
| originalBody.WithTrailingTrivia(SyntaxFactory.ElasticCarriageReturnLineFeed)); | ||
|
|
||
| // Replace the original with the new one | ||
| var newLambdaExpr = lambdaExpr.WithBody(null).WithBlock(bodyBlock); | ||
| editor.ReplaceNode(lambdaExpr, newLambdaExpr); |
There was a problem hiding this comment.
Insert a block body if the original invocation was not enclosed inside a code block
Aaronontheweb
approved these changes
Jan 17, 2024
Comment on lines
+90
to
+103
| // Make sure to replace the old invocation with the new one | ||
| var newExprSyntax = exprSyntax.ReplaceNode(invocationExpr, newInvocationExpr); | ||
|
|
||
| // Create a new block with the original lambda body as a statement | ||
| var originalBody = SyntaxFactory.ExpressionStatement(newExprSyntax); | ||
|
|
||
| // Insert the local variable declaration at the start of the lambda block | ||
| var bodyBlock = SyntaxFactory.Block( | ||
| senderVariable.WithTrailingTrivia(SyntaxFactory.ElasticCarriageReturnLineFeed), | ||
| originalBody.WithTrailingTrivia(SyntaxFactory.ElasticCarriageReturnLineFeed)); | ||
|
|
||
| // Replace the original with the new one | ||
| var newLambdaExpr = lambdaExpr.WithBody(null).WithBlock(bodyBlock); | ||
| editor.ReplaceNode(lambdaExpr, newLambdaExpr); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
Changes
Converts
to