Akka.Persistence.Sql.Common: harden SqlJournal and `SqlSnapshotStor…

…e` against initialization failures (#7325)

* Harden SQL journal in the event of failed initialization

* harden snapshot store too

---------

Co-authored-by: Gregorius Soedharmo <arkatufus@yahoo.com>

src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/SqlJournal.cs

@@ -257,8 +257,9 @@ protected bool WaitingForInitialization(object message)
                     return true;
                 case Status.Failure fail:
                     Log.Error(fail.Cause, "Failure during {0} initialization.", Self);
-                    Context.Stop(Self);
-                    return true;
+
+                    // trigger a restart so we have some hope of succeeding in the future even if initialization failed
+                    throw new ApplicationException("Failed to initialize SQL Journal.", fail.Cause);
                 default:
                     Stash.Stash();
                     return true;

src/contrib/persistence/Akka.Persistence.Sql.Common/Snapshot/SqlSnapshotStore.cs

@@ -137,8 +137,9 @@ private bool WaitingForInitialization(object message)
                     return true;
                 case Status.Failure msg:
                     Log.Error(msg.Cause, "Error during snapshot store initialization");
-                    Context.Stop(Self);
-                    return true;
+
+                    // trigger a restart so we have some hope of succeeding in the future even if initialization failed
+                    throw new ApplicationException("Failed to initialize SQL SnapshotStore.", msg.Cause);
                 default:
                     Stash.Stash();
                     return true;