added meaningful ToString() to all system messages

akkadotnet · Feb 28, 2015 · 576ab18 · 576ab18 · Petabridge-CI · Feb 28, 2015
1 parent eae216f
commit 576ab18
Show file tree

Hide file tree

Showing 4 changed files with 63 additions and 3 deletions.
diff --git a/src/core/Akka/Actor/ActorSelection.cs b/src/core/Akka/Actor/ActorSelection.cs
@@ -219,6 +219,12 @@ public ActorSelectionMessage(object message, SelectionPathElement[] elements, bo
         public SelectionPathElement[] Elements { get; private set; }
 
         public bool WildCardFanOut { get; private set; }
+
+        public override string ToString()
+        {
+            return string.Format("ActorSelectionMessage - Message: {0} - WildCartFanOut: {1} - Elements: {2}",
+                Message, WildCardFanOut, string.Join<SelectionPathElement>("/", Elements));
+        }
     }
 
     /// <summary>

diff --git a/src/core/Akka/Actor/AutoReceivedMessage.cs b/src/core/Akka/Actor/AutoReceivedMessage.cs
@@ -7,7 +7,7 @@ public interface AutoReceivedMessage : NoSerializationVerificationNeeded
     {
     }
 
-    public sealed class 
+    public sealed class
         Terminated : AutoReceivedMessage, PossiblyHarmful
     {
         public Terminated(ActorRef actorRef, bool existenceConfirmed, bool addressTerminated)
@@ -26,7 +26,7 @@ public Terminated(ActorRef actorRef, bool existenceConfirmed, bool addressTermin
 
         public override string ToString()
         {
-            return string.Format("Terminated - ActorRef: {0} - ExistenceConfirmed: {1}", ActorRef,ExistenceConfirmed);
+            return "<Terminated>: " + ActorRef + " - ExistenceConfirmed=" + ExistenceConfirmed;
         }
     }
 
@@ -39,6 +39,11 @@ public Identify(object messageId)
         }
 
         public object MessageId { get; private set; }
+
+        public override string ToString()
+        {
+            return "<Identify>: " + MessageId.ToString();
+        }
     }
 
     //response to the Identity message, get identity by Sender
@@ -52,6 +57,11 @@ public ActorIdentity(object messageId, ActorRef subject)
 
         public object MessageId { get; private set; }
         public ActorRef Subject { get; private set; }
+
+        public override string ToString()
+        {
+            return "<ActorIdentity>: " + Subject + " - MessageId=" + MessageId;
+        }
     }
 
     /// <summary>
@@ -62,7 +72,7 @@ public ActorIdentity(object messageId, ActorRef subject)
     /// it processes the message, which gets handled using the normal supervisor mechanism, and
     /// <see cref="IActorContext.Stop"/> which causes the actor to stop without processing any more messages. </para>
     /// </summary>
-    public sealed class PoisonPill : AutoReceivedMessage 
+    public sealed class PoisonPill : AutoReceivedMessage
     {
         private PoisonPill() { }
         private static readonly PoisonPill _instance = new PoisonPill();
@@ -73,6 +83,11 @@ public static PoisonPill Instance
                 return _instance;
             }
         }
+
+        public override string ToString()
+        {
+            return "<PoisonPill>";
+        }
     }
 
 
@@ -95,6 +110,11 @@ public static Kill Instance
                 return _instance;
             }
         }
+
+        public override string ToString()
+        {
+            return "<Kill>";
+        }
     }
 
 
@@ -117,5 +137,10 @@ public AddressTerminated(Address address)
         }
 
         public Address Address { get; private set; }
+
+        public override string ToString()
+        {
+            return "<AddressTerminated>: " + Address;
+        }
     }
 }
diff --git a/src/core/Akka/Dispatch/SysMsg/SystemMessage.cs b/src/core/Akka/Dispatch/SysMsg/SystemMessage.cs
@@ -22,6 +22,10 @@ public interface SystemMessage : NoSerializationVerificationNeeded
     /// </summary>
     public sealed class NoMessage : SystemMessage
     {
+        public override string ToString()
+        {
+            return "NoMessage";
+        }
     }
 
     /// <summary>
@@ -253,6 +257,11 @@ public CompleteTask(AmbientState state, Action action)
         /// </summary>
         /// <value>The set result.</value>
         public Action SetResult { get; private set; }
+
+        public override string ToString()
+        {
+            return "CompleteTask - AmbientState: " + State;
+        }
     }
 
     /// <summary>
@@ -337,6 +346,11 @@ public static Suspend Instance
                 return _instance;
             }
         }
+
+        public override string ToString()
+        {
+            return "<Suspend>";
+        }
     }
 
     /// <summary>
@@ -353,6 +367,11 @@ public static Stop Instance
                 return _instance;
             }
         }
+
+        public override string ToString()
+        {
+            return "<Stop>";
+        }
     }
 
     /// <summary>
@@ -424,6 +443,11 @@ public static Terminate Instance
                 return _instance;
             }
         }
+
+        public override string ToString()
+        {
+            return "<Terminate>";
+        }
     }
 
     public sealed class Create : SystemMessage

diff --git a/src/core/Akka/Dispatch/TaskDispatcher.cs b/src/core/Akka/Dispatch/TaskDispatcher.cs
@@ -34,6 +34,11 @@ public class AmbientState
         public ActorRef Self { get; set; }
         public ActorRef Sender { get; set; }
         public object Message { get; set; }
+
+        public override string ToString()
+        {
+            return string.Format("(Sender: {0}, Self: {1}, Message: {2})", Sender, Self, Message);
+        }
     }
 
     public class ActorTaskScheduler : TaskScheduler