Add async support for loading column sizes

akkadotnet · Feb 9, 2021 · 6df501b · 6df501b
1 parent e2507c8
commit 6df501b
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/BatchingSqlJournal.cs b/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/BatchingSqlJournal.cs
@@ -892,7 +892,7 @@ private async Task<BatchComplete> ExecuteChunk(RequestChunk chunk, IActorContext
                 await connection.OpenAsync();
 
                 // pre-load column sizes to use in queries
-                LoadColumnSizes(connection, Setup.NamingConventions);
+                await LoadColumnSizes(connection);
 
                 using (var tx = connection.BeginTransaction(Setup.IsolationLevel))
                 using (var command = (TCommand)connection.CreateCommand())
@@ -1414,22 +1414,21 @@ protected void AddParameter(TCommand command, string paramName, DbType dbType, o
         /// </para>
         /// 
         /// </summary>
-        /// <param name="connection"></param>
-        /// <param name="conventions"></param>
-        protected virtual ColumnSizesInfo LoadColumnSizesInternal(DbConnection connection, QueryConfiguration conventions)
+        /// <param name="connection">Already opened connection to the database</param>
+        protected virtual Task<ColumnSizesInfo> LoadColumnSizesInternal(DbConnection connection)
         {
-            return ColumnSizesInfo.Default;
+            return Task.FromResult(ColumnSizesInfo.Default);
         }
 
-        private void LoadColumnSizes(DbConnection connection, QueryConfiguration conventions)
+        private async Task LoadColumnSizes(DbConnection connection)
         {
             // load schema/initialize column sizes only once
             if (ColumnSizes != null)
                 return;
 
             try
             {
-                ColumnSizes = LoadColumnSizesInternal(connection, conventions);
+                ColumnSizes = await LoadColumnSizesInternal(connection);
             }
             catch (Exception exception)
             {