Skip to content

Commit

Permalink
skip racy substream spec (#5258)
Browse files Browse the repository at this point in the history
  • Loading branch information
Aaronontheweb authored Sep 6, 2021
1 parent f6e2ab9 commit eb11339
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public SubstreamSubscriptionTimeoutSpec(ITestOutputHelper helper) : base(Config,
Materializer = ActorMaterializer.Create(Sys, settings);
}

[Fact]
[Fact(Skip = "Racy")]
public void GroupBy_and_SplitWhen_must_timeout_and_cancel_substream_publisher_when_no_one_subscribes_to_them_after_some_time()
{
this.AssertAllStagesStopped(() =>
Expand All @@ -57,6 +57,13 @@ public void GroupBy_and_SplitWhen_must_timeout_and_cancel_substream_publisher_wh
publisherProbe.SendNext(1);
publisherProbe.SendNext(2);
publisherProbe.SendNext(3);

/*
* Why this spec is skipped: in the event that subscriber.ExpectSubscription() or (subscriber.ExpectNext()
* + s1SubscriberProbe.ExpectSubscription()) exceeds 300ms, the next call to subscriber.ExpectNext will
* fail. This test is too tightly fitted to the timeout duration to be reliable, although somewhat ironically
* it does validate that the underlying cancellation does work!
*/

var s1 = subscriber.ExpectNext().Item2;
// should not break normal usage
Expand Down

0 comments on commit eb11339

Please sign in to comment.