Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite SimpleDnsCache to be immutable #1226

Closed
rogeralsing opened this issue Aug 9, 2015 · 0 comments
Closed

Rewrite SimpleDnsCache to be immutable #1226

rogeralsing opened this issue Aug 9, 2015 · 0 comments

Comments

@rogeralsing
Copy link
Contributor

For context, see the conversation here: #1222

The SimpleDnsCache is mutable, but shared globally in a system extension.
Thus, its open for race conditions.
I've labeled this confirmed bug, which might be a bit harsh as there is currently only one consumer, an actor of this class, so its not a visible bug atm.
but if anyone take dependency on the extension exposing this, it will be visble.

the scala version is based on immutability and we should follow their lead on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants