Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActorMailboxSpec #1793

Closed
cconstantin opened this issue Mar 15, 2016 · 12 comments
Closed

Add ActorMailboxSpec #1793

cconstantin opened this issue Mar 15, 2016 · 12 comments

Comments

@cconstantin
Copy link
Contributor

We should port the tests for mailboxes, such as https://github.com/akka/akka/blob/master/akka-actor-tests/src/test/scala/akka/actor/ActorMailboxSpec.scala

@wmeints
Copy link
Contributor

wmeints commented Apr 15, 2016

If nobody else is working on this I'd like to take this one up.

@marcpiechura
Copy link
Contributor

Go ahead 👍

@wmeints
Copy link
Contributor

wmeints commented Apr 16, 2016

I notice there's a file MailboxesSpec in Akka.Test/Dispatcher. This test implements a few test cases for the mailboxes. Would you like to have the new tests in the same spot?

@marcpiechura
Copy link
Contributor

@wmeints I think that are different specs, the MailboxesSpec tests a actual implementation weather the ActorMailboxSpec only tests that the actor is using the correct mailbox.

This seems to be the counterpart of the MailboxesSpec
https://github.com/akka/akka/blob/master/akka-actor-tests/src/test/scala/akka/dispatch/PriorityDispatcherSpec.scala

@wmeints
Copy link
Contributor

wmeints commented Apr 16, 2016

👍 Will write the tests separate of the mailboxesspec.

@wmeints
Copy link
Contributor

wmeints commented Apr 19, 2016

Does Akka.NET support bounded mailboxes right now? I'm running into an issue where an actor cannot be created because I used IBoundedMessageQueueSemantics.

public class BoundedQueueReportingActor : MailboxReportingActor, IRequiresMessageQueue<IBoundedMessageQueueSemantics>
{

}

@wmeints
Copy link
Contributor

wmeints commented Apr 19, 2016

Since there are only a few mailboxes that are supported I'm going to add tests for those and leave the rest for another time. Hope that's okay :-)

@Horusiath
Copy link
Contributor

@wmeints no problem ;)

@marcpiechura
Copy link
Contributor

@wmeints could you create issues for the missing mailboxes or create a list here?
We should keep track of them.

@wmeints
Copy link
Contributor

wmeints commented Apr 20, 2016

Sure, I can do that. Will take a look at it tonight and create issues for the individual mailbox types.

marcpiechura pushed a commit that referenced this issue Apr 21, 2016
Added some basic specs for the mailbox/actor combinations in Akka.NET.
Bounded dispatcher and mailbox configurations haven't been added yet
as these are not supported right now.

Takes care of issue #1793
@wmeints
Copy link
Contributor

wmeints commented Apr 22, 2016

Just noticed that there is a BoundedQueBasedMailbox class. The only thing missing for the bounded mailboxes is BoundedMailbox class. I think this one should, just like the UnboundedMailbox, be an alias for a sane implementation.

Will create another pull request to port the test cases for the bounded mailbox that is available, so we have that covered.

@alexvaluyskiy alexvaluyskiy added this to the 1.1.0 milestone Jun 19, 2016
@alexvaluyskiy
Copy link
Contributor

@wmeints could we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants