-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ActorMailboxSpec #1793
Comments
If nobody else is working on this I'd like to take this one up. |
Go ahead 👍 |
I notice there's a file MailboxesSpec in Akka.Test/Dispatcher. This test implements a few test cases for the mailboxes. Would you like to have the new tests in the same spot? |
@wmeints I think that are different specs, the MailboxesSpec tests a actual implementation weather the ActorMailboxSpec only tests that the actor is using the correct mailbox. This seems to be the counterpart of the MailboxesSpec |
👍 Will write the tests separate of the mailboxesspec. |
Does Akka.NET support bounded mailboxes right now? I'm running into an issue where an actor cannot be created because I used
|
Since there are only a few mailboxes that are supported I'm going to add tests for those and leave the rest for another time. Hope that's okay :-) |
@wmeints no problem ;) |
@wmeints could you create issues for the missing mailboxes or create a list here? |
Sure, I can do that. Will take a look at it tonight and create issues for the individual mailbox types. |
Added some basic specs for the mailbox/actor combinations in Akka.NET. Bounded dispatcher and mailbox configurations haven't been added yet as these are not supported right now. Takes care of issue #1793
Just noticed that there is a BoundedQueBasedMailbox class. The only thing missing for the bounded mailboxes is BoundedMailbox class. I think this one should, just like the UnboundedMailbox, be an alias for a sane implementation. Will create another pull request to port the test cases for the bounded mailbox that is available, so we have that covered. |
@wmeints could we close it? |
We should port the tests for mailboxes, such as https://github.com/akka/akka/blob/master/akka-actor-tests/src/test/scala/akka/actor/ActorMailboxSpec.scala
The text was updated successfully, but these errors were encountered: