-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for NoSender serialization bugs #1037
Fixes for NoSender serialization bugs #1037
Conversation
thanks, @ssoshchepkov - looks like we've overlooked this one. |
…-1036 Fixes for NoSender serialization bugs
Im not sure this fix is correct. |
@rogeralsing ok, I reverted it. I'll let you take a closer look and see what's really going on. |
Turns out that its @ssoshchepkov if you want, could you adapt the PR to treat NoSender as null instead? /**
* Default placeholder (null) used for "!" to indicate that there is no sender of the message,
* that will be translated to the receiving system's deadLetters.
*/
final val noSender: ActorRef = null |
@rogeralsing won't that conflict with your PR that turns |
That code could just go away if we do this. Or? |
@rogeralsing I've made changes to treat |
I think you have to send a fresh one. I dont think a PR can be re-opened once merged (as this was merged and then a revert patch applied) |
Fixes for
NoSender
actor serialization bugs described in #1036.