-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoteDaemon bug, not removing children #1068
RemoteDaemon bug, not removing children #1068
Conversation
Renamed RemoteDaemon Added Hooks Added spin-retry updates of parent2children Added fake remote terminator argument Added addChildParentNeedsWatch
I've found a big issue in the last change to this PR. Apparently, when the RemoteSystemDaemon tries to send messages back to the calling system, there is no This looks critical to me, if the remoting layer "forgets" to set the active transport before sending messages under some conditions. |
I Updated the PR, fixed the problem with outbound actorrefs in RemoteSystemDaemon. (which was an error in Serialization.SerializeActorRef, not as I first suspected, an error with active transports) However, there is another bug that surfaces if the |
The failing test might be racy or something, it works locally, rerun? |
…base, and replaced it with a serializser overload `ToBinaryWithAddress` that applies the thread static magic internally.
This is great work @rogeralsing - I'll give it a full review tomorrow. |
Just to avoid any confusion, this is unrelated to #1062 |
…fication RemoteDaemon bug, not removing children
This fixes the issue that remote deployed actors was not removed from the remote daemon when
.Stop(remoteref)
. which resulted in that it was impossible to re-deploy remote actors with the same name,Renamed RemoteDaemon to RemoteSystemDaemon (was changed in JVM)
Added Hooks
Added spin-retry updates of parent2children
Added fake remote terminator argument (using deadletters instead of true termination hooks as those are still missing)
Added AddChildParentNeedsWatch