Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set multinodetests to run on 'all' builds #1083

Merged
merged 3 commits into from
Jun 23, 2015

Conversation

Aaronontheweb
Copy link
Member

Minor change, but going forward all multinodetests will run on build.

This is a big step towards getting 1.1 out the door.

@Aaronontheweb
Copy link
Member Author

Builds ran successfully several times on local machine, but experienced a hang here:

[00:53:26] :     [Step 1/1] [NODE5][6/23/2015 12:53:26 AM][DEBUG][[akka://MultiNodeClusterSpec/user/TestConductorClient]]: transition AwaitDone, Akka.Remote.TestKit.ClientFSM+Data -> Failed, Akka.Remote.TestKit.ClientFSM+Data
[00:53:26] :     [Step 1/1] [NODE5][6/23/2015 12:53:26 AM][DEBUG][[akka://MultiNodeClusterSpec/user/TestConductorClient]]: processing Event: <<Terminated>: [akka://MultiNodeClusterSpec/user/$b] - ExistenceConfirmed
[00:53:26] :     [Step 1/1] [NODE5][6/23/2015 12:53:26 AM][DEBUG][[akka://MultiNodeClusterSpec/user/TestConductorClient]]: unhandled event <Terminated>: [akka://MultiNodeClusterSpec/user/$b] - ExistenceConfirmed
[00:53:26] :     [Step 1/1] [NODE5][6/23/2015 12:53:26 AM][DEBUG][[akka://MultiNodeClusterSpec/user/TestConductorClient]]: transition Failed, Akka.Remote.TestKit.ClientFSM+Data -> Failed, Akka.Remote.TestKit.ClientFSM+Data

@Aaronontheweb
Copy link
Member Author

I upgraded from a 2-core, ~4GB machine to a 4-core, ~8GB machine and that appears to have made the difference for the TestConductor, which would just deadlock at the very beginning of the multi-node tests before. I think it requires a minimum level of concurrency that it couldn't achieve with just 2 cores before.

The good news is that the new machines are still low-powered enough to expose race conditions in the tests (hence #1089,) so I think this is a happy medium.

rogeralsing added a commit that referenced this pull request Jun 23, 2015
Set multinodetests to run on 'all' builds
@rogeralsing rogeralsing merged commit d85625e into akkadotnet:dev Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants