147 circuit breaker #1201
Merged
147 circuit breaker #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// inappropriate time. In other words, the Java environment or | ||
| /// Java application is not in an appropriate state for the requested | ||
| /// operation. | ||
| /// </summary> |
There was a problem hiding this comment.
This summary is quite inappropriate here.
There was a problem hiding this comment.
@Horusiath I missed that one -- will correct and resubmit the pull request
MAOliver
force-pushed
the
147_CircuitBreaker
branch
2 times, most recently
from
5789005 to
d8aaed5
Compare
- Add passing tests from akka 2.0.5 - Add CircuitBreakerState.cs with Open, HalfOpen, and Closed states - Add AtomicState which extends AtomicLong (mirrors functionality of State trait) - Add OpenCircuitException - Add CircuitBreaker documentation - Remove Scheduler from current implementation - Remove inappropriate xmldoc on illegalstateexception - Update flow on AtomicState::CallThrough method to be clearer and more closely match original - Add clarifying comments on "Fire and forget" NotifyTransitionListeners
MAOliver
force-pushed
the
147_CircuitBreaker
branch
from
d8aaed5 to
7e16834
Compare
|
@rogeralsing @Horusiath let me know if this works. I squashed all the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#147
Ultimately I wound up ignoring the IScheduler and ExecutionContext / SynchronizationContext. I have implemented the tests from the Akka.io CircuitBreakerSpec tests and we can always come back later and add in the scheduler and execution context in a later commit and add suitable default values to a constructor.