Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced generic exceptions with more specific ones #1205

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

sean-gilliam
Copy link
Member

Reference #1192

This PR replaces the generic exceptions with more specific ones. This
should help make debugging easier for apps that work with Akka.NET.

Reference akkadotnet#1192

This PR replaces the generic exceptions with more specific ones. This
should help make debugging easier for apps that work with Akka.NET.
@rogeralsing
Copy link
Contributor

Looks great!
The failed tests looks a bit funky though, do we have code that expects the old exception types anywhere?

@sean-gilliam
Copy link
Member Author

Thanks :)

Hmm. At first glance, it looks to be timeout related. Maybe my changes on src/core/Akka.TestKit/TestKitBase.cs from Exception to TimeoutException could be causing this?

I'll dig it to it.

@sean-gilliam
Copy link
Member Author

Well I just ran those tests again on my end and I get green check marks. Maybe something going on with the build server?

@rogeralsing
Copy link
Contributor

@Aaronontheweb can we do something about the buildserver rebuilds, add a bot that we ourselves can activate or something?
Its been frustrating for a long time now that nobody else can activate this

@Aaronontheweb
Copy link
Member

@rogeralsing yeah, that's something I want to be able to do with Hubot but we don't have it working yet. cc @skotzko

In the meantime, I can give you guys accounts for restarting builds. Would that work?

Aaronontheweb added a commit that referenced this pull request Aug 5, 2015
Replaced generic exceptions with more specific ones
@Aaronontheweb Aaronontheweb merged commit 0969040 into akkadotnet:dev Aug 5, 2015
@sean-gilliam sean-gilliam deleted the specific-exceptions branch December 14, 2015 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants