Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1416 created ReceiveActor implementation of AtLeastOnceDeliveryActor #1469

Conversation

maxim-s
Copy link
Contributor

@maxim-s maxim-s commented Nov 26, 2015

No description provided.

@Horusiath
Copy link
Contributor

👍 Well done :) Build is failing but this seems to be more related to multinode test runner than the changes introduced.

@maxim-s maxim-s force-pushed the receive-actor-with-at-least-once-delivery-actor-1416 branch from 6c5afc9 to 4d1d79b Compare November 30, 2015 09:33
@Aaronontheweb
Copy link
Member

@Horusiath


 SqliteJournalQuerySpec.Journal_queried_on_Manifest_returns_events_with_particular_manifest 

First failure:      1469    #1618   maxim.salamatk… (1)   30 Nov 15 09:38
Failed: Timeout 00:00:03 while waiting for a message of type Akka.Persistence.WriteMessagesSuccessful 
Expected: True
Actual:   False
   at Akka.TestKit.Xunit2.XunitAssertions.Fail(String format, Object[] args) in D:\BuildAgent\work\49b164d63843fb4\src\contrib\testkits\Akka.TestKit.Xunit2\XunitAssertions.cs:line 22
   at Akka.TestKit.TestKitBase.InternalExpectMsgEnvelope[T](Nullable`1 timeout, Action`2 assert, String hint, Boolean shouldLog) in D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.TestKit\TestKitBase_Expect.cs:line 196
   at Akka.TestKit.TestKitBase.InternalExpectMsgEnvelope[T](Nullable`1 timeout, Action`1 msgAssert, Action`1 senderAssert, String hint) in D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.TestKit\TestKitBase_Expect.cs:line 179
   at Akka.TestKit.TestKitBase.InternalExpectMsg[T](Nullable`1 timeout, Action`1 msgAssert, String hint) in D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.TestKit\TestKitBase_Expect.cs:line 154
   at Akka.TestKit.TestKitBase.ExpectMsg[T](Nullable`1 duration, String hint) in D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.TestKit\TestKitBase_Expect.cs:line 29
   at Akka.Persistence.Sql.Common.TestKit.SqlJournalQuerySpec.WriteEvents() in D:\BuildAgent\work\49b164d63843fb4\src\contrib\persistence\Akka.Persistence.Sql.Common.TestKit\SqlJournalQuerySpec.cs:line 123
   at Akka.Persistence.Sqlite.Tests.SqliteJournalQuerySpec..ctor(ITestOutputHelper output) in D:\BuildAgent\work\49b164d63843fb4\src\contrib\persistence\Akka.Persistence.Sqlite.Tests\SqliteJournalQuerySpec.cs:line 23

@Aaronontheweb
Copy link
Member

Re-running the MNTR now

Aaronontheweb added a commit that referenced this pull request Dec 1, 2015
…e-delivery-actor-1416

#1416 created ReceiveActor implementation of AtLeastOnceDeliveryActor
@Aaronontheweb Aaronontheweb merged commit bf0f520 into akkadotnet:dev Dec 1, 2015
@@ -112,4 +114,118 @@
</Target>
-->

<Choose>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah! I missed this when I first looked at the PR and merged it.

We'll need to remove that <Choose> block below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my mistake, I'll check it next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants