Preparations before Akka.Cluster.Tools and Akka.Cluster.Sharding packaging #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var settings = ClusterShardingSettings.Create(_system).WithRole(role); | ||
| var startMsg = new ClusterShardingGuardian.StartProxy(typeName, settings, idExtractor, shardResolver); | ||
| var started = await _guardian.Value.Ask<ClusterShardingGuardian.Started>(startMsg, timeout); | ||
| _regions.TryAdd(typeName, started.ShardRegion); |
There was a problem hiding this comment.
What happens if two calls to StartProxyAsync is called?
The current TryAdd will only add the first and drop the 2nd on the floor.
Is that the intended behavior?
There was a problem hiding this comment.
This doesn't necessarily matters, as this asynchronous async call will return the same actor ref (see ClusterShardingGuardian handler).
Aaronontheweb
added a commit
that referenced
this pull request
Jan 4, 2016
Preparations before Akka.Cluster.Tools and Akka.Cluster.Sharding packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
First PR of
Akka.Cluster.ToolsandAkka.Cluster.Shardingintroduced two fresh modules. However they were missing some parts, like lack of API encapsulation. Purpose of this PR is to prepare them for nightly releases.Modifications
Akka.Cluster.ToolsandAkka.Cluster.Shardingand included those assemblies in build.fsx.ShardRegionandShardRegionProxyfromClusterShardingextension.Result
Enclosed some of the API to reduce noise generated by types and prevent accidental missuse. Changed control message to follow C# namespacing convention. Improved contol messages serialization.