Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1251 Port Akka.Remote MultiNodeSpec: RemoteNodeRestartDeathWatchSpec #1600

Conversation

maxim-s
Copy link
Contributor

@maxim-s maxim-s commented Dec 24, 2015

No description provided.

@maxim-s
Copy link
Contributor Author

maxim-s commented Jan 7, 2016

still WIP

@maxim-s maxim-s force-pushed the 1251-remote-node-restart-death-watch-spec branch from 71d934e to 23ac2c1 Compare January 30, 2016 09:46
@maxim-s
Copy link
Contributor Author

maxim-s commented Jan 30, 2016

Balckhole RateMBit should be zero https://github.com/akka/akka/blob/master/akka-multi-node-testkit/src/main/scala/akka/remote/testconductor/Player.scala#L229

Helios has both trttl and gremlin

gremlin = "Akka.Remote.Transport.FailureInjectorProvider,Akka.Remote"
      trttl = "Akka.Remote.Transport.ThrottlerProvider,Akka.Remote"

MsgEncoder should handle ThrottleMsg with ThrottleMsg SetFailure(TCP.FailType.Throttle)
https://github.com/akka/akka/blob/master/akka-multi-node-testkit/src/main/scala/akka/remote/testconductor/DataTypes.scala#L93

@@ -76,6 +76,7 @@ public void Encode(IConnection connection, object message, out List<IByteBuf> en
throttle =>
w.SetFailure(
InjectFailure.CreateBuilder()
.SetFailure(TCP.FailType.Throttle)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Aaronontheweb added a commit that referenced this pull request Feb 1, 2016
…watch-spec

#1251 Port Akka.Remote MultiNodeSpec: RemoteNodeRestartDeathWatchSpec
@Aaronontheweb Aaronontheweb merged commit 3390255 into akkadotnet:dev Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants