Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue with Helios message ordering #1638

Merged
merged 1 commit into from
Jan 13, 2016

Conversation

Aaronontheweb
Copy link
Member

Resolves #1628 - the enhanced MNTR logs revealed that Helios delivering messages for a remotely deployed actor before the remotely deployed actor was created were the problem.

This will hurt throughput to some extent in Helios, but it's more important to be functionally correct. I would like to make this part of the v1.0.6 release as it fixes what is a critical issue in my opinion.

@Horusiath
Copy link
Contributor

👍 but I'd like to know if this will affect performance somehow?

@Aaronontheweb
Copy link
Member Author

@Horusiath tell you what - let me write a quick benchmark...

@Aaronontheweb
Copy link
Member Author

Unfortunately, I can't give a connection benchmark for Helios right now - there's an intermittent disassociation that occurs that blocks the benchmarks as they're currently written from running.

I'm opening some issues to fix this stuff correctly within Helios - I already have to make some changes there in order to make Helios wire-compatible with DotNetty (without those changes, switching to the DotNetty transport becomes a breaking change that requires downtime.)

Strongly recommend merging this. Correct behavior >>>>> performance.

@Aaronontheweb
Copy link
Member Author

It will take me a significant amount of time to fix the Helios issue; not a monkey patch, in other words. I really want to ditch Helios altogether and move onto DotNetty when I'm confident that the AkkaProtocolSpec is working correctly.

Horusiath added a commit that referenced this pull request Jan 13, 2016
fixes issue with Helios message ordering
@Horusiath Horusiath merged commit 71c420b into akkadotnet:dev Jan 13, 2016
@Aaronontheweb Aaronontheweb deleted the helios-fix branch January 13, 2016 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition with Akka.Remote.Tests.Multinode.RemoteRoundRobinSpec
3 participants