[WIP] Moving towards .NET Standard/.NET Core compatibility #2134
Conversation
| @@ -295,7 +295,7 @@ private void CreateCoordinator() | |||
|
|
|||
| foreach (var typeName in typeNames) | |||
| { | |||
| var rebalanceEnabled = string.Equals(typeName, "rebalancing", StringComparison.InvariantCultureIgnoreCase); | |||
| var rebalanceEnabled = string.Equals(typeName, "rebalancing", StringComparison.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
MS recommends to replace InvariantCultureIgnoreCase to OrdinalIgnoreCase in many cases
alexvaluyskiy
changed the title
|
@akkadotnet/developers So, the main question. What should we do with BinarySerialization in exceptions, and with SerializableAttribute? We could just remove it, as many projects did. Or we can add compilation directives, as I did here Akka.Net doesn't use BinarySerialization. So, why we are using these attributes? |
|
paging @JeffCyr - questions about unsafe threading on .NET Core :p |
alexvaluyskiy
force-pushed
the
netcore
branch
4 times, most recently
from
8c465ae to
0e95adf
Compare
| @@ -165,7 +165,7 @@ public static GraphInterpreter Current | |||
| get | |||
| { | |||
| if (CurrentInterpreter.Value[0] == null) | |||
| throw new ApplicationException("Something went terribly wrong!"); | |||
| throw new InvalidOperationException("Something went terribly wrong!"); | |||
There was a problem hiding this comment.
NetCore doesn't have ApplicationException, changed to InvalidOperationException
| @@ -69,7 +72,23 @@ internal class DedicatedThreadPoolSettings | |||
| if (numThreads <= 0) | |||
| throw new ArgumentOutOfRangeException("numThreads", string.Format("numThreads must be at least 1. Was {0}", numThreads)); | |||
| } | |||
| #else | |||
| public DedicatedThreadPoolSettings(int numThreads, string name = null, TimeSpan? deadlockTimeout = null) | |||
There was a problem hiding this comment.
Added a different constructor for NetCore version, without ApartmentState
|
Say it ain't so! |
|
We should create a feature branch here instead of this PR |
|
@alexvaluyskiy at the next contributor's meeting, let's sort that out for how we want to do this incrementally. |
|
@Aaronontheweb Ok. |
|
Does AKKA.Net now work with ASP.Net Core? http://fizzylogic.nl/2016/05/22/Using-Akka-NET-from-your-ASP-NET-core-application/ |
|
@sdanishali No it does not, it only supports full .NET framework. This is mentioned in the comments of the post :-) Sorry dude, it's going to take some time before Akka.NET supports the .NET standard way of doing things. Until then use net45 or higher instead. |
!Important! This PR is not about introducing NET CLI or xproj/project.json in the source code. It makes the source code easier to introduce .NET Platform compatibility in the future.
I used some ideas from this thread #992
Right now the sources match NetStandard 1.5, but it possible to achieve 1.3 in the future