Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to abort joining of seed nodes #3863

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

ismaelhamed
Copy link
Member

Port #23551

@ismaelhamed
Copy link
Member Author

@Aaronontheweb there's some documentation related to these new settings, but the Akka.NET documentation is so different in this topic (cluster) that I'm not sure where to put it.

@ismaelhamed ismaelhamed force-pushed the join-timeout branch 3 times, most recently from 47af948 to cfe7b25 Compare July 25, 2019 15:58
@Aaronontheweb
Copy link
Member

@ismaelhamed do the best you can to add it to this PR, and I'll help you out if need be

@ismaelhamed
Copy link
Member Author

ismaelhamed commented Sep 2, 2019

@Aaronontheweb it's part of the Joining To Seed Nodes section in the Cluster Usage document. But the whole thing is missing. Maybe we're better off adding another PR with all the missing documentation related to the cluster later on.

@ismaelhamed
Copy link
Member Author

@Aaronontheweb not sure where all those errors are coming from, because the unit tests are passing just fine in my machine.

@Aaronontheweb
Copy link
Member

@ismaelhamed it's usually due to all of the blocking calls inside the TestKit and that we're running many different specs concurrently. It's a regular nuisance

@ismaelhamed ismaelhamed changed the title [WIP] Add timeout to abort joining of seed nodes Add timeout to abort joining of seed nodes Nov 16, 2019
@ismaelhamed
Copy link
Member Author

@Aaronontheweb LOL... I thought I'd never see this PR green.

@Aaronontheweb
Copy link
Member

weird, got a compilation failure this time? wtf

@ismaelhamed
Copy link
Member Author

@ismaelhamed it's usually due to all of the blocking calls inside the TestKit and that we're running many different specs concurrently. It's a regular nuisance

Would automerge be an option for approved pull requests?

@Aaronontheweb
Copy link
Member

@ismaelhamed I have to review stuff sometimes when these specs fail just to be sure we didn't make the problem worse. We have one PR open where the MNTR has failed in the same location every time we've run it, even though there's nothing obvious in the PR that would have affected it. That's why we're a but judicious about combing through these before merging.

@Aaronontheweb Aaronontheweb merged commit 5cf8002 into akkadotnet:dev Nov 21, 2019
@Aaronontheweb Aaronontheweb added this to the 1.4.0 milestone Nov 21, 2019
@ismaelhamed
Copy link
Member Author

@ismaelhamed I have to review stuff sometimes when these specs fail just to be sure we didn't make the problem worse. We have one PR open where the MNTR has failed in the same location every time we've run it, even though there's nothing obvious in the PR that would have affected it. That's why we're a but judicious about combing through these before merging.

Agree. It's just that the build system seems to frequently fail (regular nuisance like you said), and that makes some PR stale for a long time --I opened this PR in July and have force-pushed 8 times since then.

@ismaelhamed ismaelhamed deleted the join-timeout branch November 21, 2019 17:06
@Aaronontheweb
Copy link
Member

Yeah, that's a nuisance - we need to get some changes implemented in the TestKit and in the way our test suites themselves run in order to alleviate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants