-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout to abort joining of seed nodes #3863
Conversation
@Aaronontheweb there's some documentation related to these new settings, but the Akka.NET documentation is so different in this topic (cluster) that I'm not sure where to put it. |
47af948
to
cfe7b25
Compare
@ismaelhamed do the best you can to add it to this PR, and I'll help you out if need be |
@Aaronontheweb it's part of the Joining To Seed Nodes section in the Cluster Usage document. But the whole thing is missing. Maybe we're better off adding another PR with all the missing documentation related to the cluster later on. |
66d7adc
to
7e58a87
Compare
7e58a87
to
70015b7
Compare
70015b7
to
90ef168
Compare
@Aaronontheweb not sure where all those errors are coming from, because the unit tests are passing just fine in my machine. |
@ismaelhamed it's usually due to all of the blocking calls inside the |
e212568
to
9e03b0e
Compare
9e03b0e
to
4b5fa42
Compare
4b5fa42
to
ff920e8
Compare
@Aaronontheweb LOL... I thought I'd never see this PR green. |
ff920e8
to
7e21156
Compare
weird, got a compilation failure this time? wtf |
Would automerge be an option for approved pull requests? |
@ismaelhamed I have to review stuff sometimes when these specs fail just to be sure we didn't make the problem worse. We have one PR open where the MNTR has failed in the same location every time we've run it, even though there's nothing obvious in the PR that would have affected it. That's why we're a but judicious about combing through these before merging. |
Agree. It's just that the build system seems to frequently fail (regular nuisance like you said), and that makes some PR stale for a long time --I opened this PR in July and have force-pushed 8 times since then. |
Yeah, that's a nuisance - we need to get some changes implemented in the |
Port #23551