Stop DeadLetterListener on terminate if LogDeadLettersDuringShutdown is disabled #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
Nov 16, 2019
| } | ||
| finally { Shutdown(sys); } | ||
| } | ||
|
|
ismaelhamed
force-pushed
the
log-deadletters
branch
2 times, most recently
from
618aef1 to
d47d00f
Compare
|
Failure on two specs here related to these changes:
Might be an issue with the way that test is written. Also, needs an API approval. |
ismaelhamed
force-pushed
the
log-deadletters
branch
from
d47d00f to
df3357e
Compare
ismaelhamed
force-pushed
the
log-deadletters
branch
from
df3357e to
0ccbd99
Compare
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Dec 20, 2019
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Dec 20, 2019
Aaronontheweb
pushed a commit
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we never had a chance of disabling
log-dead-letters-during-shutdown