Fix/inbox actor reference #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my rebase, I've dropped the StringLike changes as noted here: #3412 (comment) Additionally, the changes made to StringLike.cs appear to be superseded in the latest on dev: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka/Util/StringLike.cs |
ghost
mentioned this pull request
|
I missed the fact that this isn't building. Will look and fix it. |
|
@nagytech nah, I think you're in good shape - the build failure is an Akka.Streams test. @IgorFedchenko is working on some changes that we think will reduce the frequency of racy test failures in our suite, as that's the number one source of frustration for regular Akka.NET contributors. But no worries, this failure is unrelated to your changes and I'll re-run it to verify. |
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Dec 20, 2019
* Inbox.Actor refactoring * Inbox Actor changes and StringLike changes * Formatted * Formatting
Aaronontheweb
pushed a commit
that referenced
this pull request
Dec 20, 2019
* Inbox.Actor refactoring * Inbox Actor changes and StringLike changes * Formatted * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing nbparrell/akka.net:dev and addressing the outstanding comments in PR #3412