Add Serialization.WithTransport overload that takes TState #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to11mtm
force-pushed
the
serialization-withtransport-tstate
branch
from
1f5031a to
cf2691a
Compare
to11mtm
force-pushed
the
serialization-withtransport-tstate
branch
from
cf2691a to
6a43275
Compare
to11mtm
commented
Feb 7, 2021
| var payloadType = e.Payload.GetType(); | ||
| var serializer = Serialization.FindSerializerForType(payloadType, Configuration.DefaultSerializer); | ||
|
|
||
| var serializer = Serialization.FindSerializerForType(e.Payload.GetType(), Configuration.DefaultSerializer); |
There was a problem hiding this comment.
Idea here is to avoid a local we don't use anywhere else.
|
|
||
| // TODO: hack. Replace when https://github.com/akkadotnet/akka.net/issues/3811 | ||
| string manifest = ""; | ||
| var binary = Akka.Serialization.Serialization.WithTransport(Serialization.System, () => | ||
| var (binary,manifest) = Akka.Serialization.Serialization.WithTransport(Serialization.System,(e.Payload,serializer) ,(state) => |
There was a problem hiding this comment.
by deconstructing here, we avoid requiring a capture on manifest.
| { | ||
|
|
||
| if (serializer is SerializerWithStringManifest stringManifest) | ||
| var (thePayload, theSerializer) = state; | ||
| string thisManifest = ""; |
There was a problem hiding this comment.
We're keeping a local here because changing this into a Ternary at end was both:
- Harder to read
- Slower because the complex ternary doesn't optimize well =/
|
It looks like in Sql.Common |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following method to Akka.Serialization.Serialization:
The purpose of this overload is to allow a TState value to be passed into the
actionwhen executed, allowing consumers to avoid allocations due to delegate captures if present.It looks like remoting already does something similar to this internally since it has access to the right internals, but there are other aspects of Akka (specifically persistence) that could benefit from this overload.
This PR also contains a benchmark of both versions of
WithTransport. It looks like we are a little bit faster:I'm not sure why it comes up slower with
[MemoryDiagnoser], but important thing is we save ~90 bytes here:That may not look like much but since this is called deep in pipelines I'm expecting at least some gains in Persistence benches. Working on looking at that in Sql.Common