Allow cluster singleton zero buffer size to disable buffering #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorFedchenko
commented
Feb 9, 2021
| if (bufferSize <= 0) | ||
| throw new ArgumentException("bufferSize must be positive", nameof(bufferSize)); | ||
| if (bufferSize < 0) | ||
| throw new ArgumentException("bufferSize must not be negative", nameof(bufferSize)); |
There was a problem hiding this comment.
The 0 value is actually supported in the code:
So this is just a minor validation issue.
IgorFedchenko
commented
Feb 9, 2021
| @@ -30,40 +30,38 @@ public class ReceiveTimeoutSpecs : TestKit | |||
| public class CheckTimeout : INotInfluenceReceiveTimeout { } | |||
| public class ReceiveTimeoutActor : ReceiveActor | |||
| { | |||
| private bool _timedOut = false; | |||
| private readonly TimeSpan _inactivityTimeout; | |||
There was a problem hiding this comment.
Nevermind, I will fix this racy spec in separate PR: #4775
|
PR is sometimes passing, sometimes fails on some racy queries - but it is ready for review and merge I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4763