Fix Akka.API.Tests spec always throws NRE when failed in CI/CD pipeline #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think you can just get this line back:
https://github.com/akkadotnet/akka.net/pull/4844/files#diff-bac245bb155e2a86b4f2d26e6059df95a7e7161cc1ba4fc740fd3cc1afa9153bL37
There was an issue for that with fix that we accidently removed in previous PR: #4765
IgorFedchenko
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in FrameworkAssertReporter that is being called inside the DiffReporter class is buggy in a CI/CD environment because it is trying to be clever, could not distinguish between XUnit and XUnit2, and will throw Null Reference Exception every time it ran.
This is probably fixed in latest version of ApiApprover but we couldn't switch to the latest version because the latest ApiGenerator returns a different API report format.
FIX: This hack removes FrameworkAssertReporter from the possible reporter list and retains all of the other reporters in DiffReporter