Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made Deploy methods virtual #4868

Merged

Conversation

Aaronontheweb
Copy link
Member

Made the Deploy methods virtual so Deploy can be overridden in subsequent systems to carry additional actor information.

Made the `Deploy` methods virtual so `Deploy` can be overridden in subsequent systems to carry additional actor information.
@Arkatufus Arkatufus self-requested a review March 23, 2021 18:23
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) March 23, 2021 18:40
@Aaronontheweb Aaronontheweb disabled auto-merge March 23, 2021 20:15
@Aaronontheweb Aaronontheweb merged commit 37f5575 into akkadotnet:dev Mar 23, 2021
@Aaronontheweb Aaronontheweb deleted the props/cleanup-virtual-deploy branch March 23, 2021 20:16
This was referenced Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants