Consolidate intercept #5033
Merged
Consolidate intercept #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
May 24, 2021
| protected async Task InterceptAsync(Func<Task> asyncActionThatThrows) | ||
|
|
||
| [Obsolete("Use AssertThrows instead.")] | ||
| protected void Intercept(Action actionThatThrows) |
There was a problem hiding this comment.
Keeping this one since there are a bunch of tests using it, as a catch-all-exceptions, which is dubious at best.
|
I meant to open this PR as a Draft, consider it as such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are a few
Interceptmethods included inAkkaSpec, but they lack cohesion in their implementations. This PR aims at solving this by consolidating all of them under a single one that also overcome their biggest limitation: not unwrappingAggregateExceptions, which force users to deal with these inside the tests themselves.This PR also brings along the
AssertThrowsmethod (a proper implementation of theInterceptthat returnsvoidinstead), which should be the preferred between the two when no further inspection of the caught exception is needed.Hopefully this will make it porting unit tests more straight forward and better aligned with the JVM.