Fix Akka.Remote serialization exception bubbling and messages #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Jun 9, 2021
Aaronontheweb
requested changes
Jun 9, 2021
| var o = new object(); | ||
| var ex = o.Invoking(s => MessageSerializer.Deserialize((ExtendedActorSystem)Sys, serialized)).Should() | ||
| .Throw<SerializationException>() | ||
| .WithMessage("Failed to deserialize object with serialization id [6] (manifest []).") |
There was a problem hiding this comment.
This literally reproduces the error we want to get rid of in #5062
| //.WithInnerExceptionExactly<SerializationException>() | ||
| //.WithMessage("Failed to deserialize object with serialization id [11] (manifest [E]).") | ||
| .WithInnerExceptionExactly<SerializationException>() | ||
| .WithMessage("Failed to deserialize object with serialization id [13] (manifest [SM])."); |
There was a problem hiding this comment.
Your use case and reproduction here is wrong - need to have a scenario where SomeMessage isn't registered at all, not that it fails during deserialization.
The goal of this bug is to unpack the inner exception and throw that - so the user gets a clear error message: that the payload carried by an ActorSelection couldn't be found because of a missing manifest, not that the ActorSelection itself couldn't be deserialized.
…ka.net into #5062_Fix_exception_message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5062