Add failure handling for BatchingSqlJournal SelectCurrentPersistenceIds message batching #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds message batching
…llow the original failure cause, create a confusing error log, and blow up BatchingSqlJournal failure handling.
Arkatufus
commented
Jun 15, 2021
| default: | ||
| throw new Exception($"Unknown persistence journal request type [{request.GetType()}]"); | ||
| Log.Error(cause, $"Batching failure not reported to original sender. Unknown batched persistence journal request type [{request.GetType()}]."); |
There was a problem hiding this comment.
Throwing would swallow the original failure cause, create confusing error message, and blow up BatchingSqlJournal.
Arkatufus
commented
Jun 15, 2021
| @@ -1096,10 +1104,12 @@ protected virtual async Task HandleSelectCurrentPersistenceIds(SelectCurrentPers | |||
| command.Parameters.Clear(); | |||
| AddParameter(command, "@Ordering", DbType.Int64, message.Offset); | |||
|
|
|||
| var reader = await command.ExecuteReaderAsync(); | |||
| while (await reader.ReadAsync()) | |||
| using (var reader = await command.ExecuteReaderAsync()) | |||
There was a problem hiding this comment.
Need to add using to make sure that the DataReader is properly closed and disposed. Failure to dispose the DataReader can cause rollback failure when the batch needs to be rolled back.
Arkatufus
deleted the
FIX_Persistence_Batching_SelectCurrentPersistenceIds_fail_handler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing failure handling, following SqlJournal failure handling behaviour