log full exception upon deserialization failure #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jul 2, 2021
| @@ -1500,7 +1500,7 @@ private bool WriteSend(EndpointManager.Send send) | |||
| { | |||
| _log.Error( | |||
| ex, | |||
| "Serializer not defined for message type [{0}]. Transient association error (association remains live)", | |||
| "Serialization failed for message [{0}]. Transient association error (association remains live)", | |||
There was a problem hiding this comment.
Made this message less specific, since we don't necessarily know why an outbound write failed.
There was a problem hiding this comment.
(the inner exception should tell us)
Aaronontheweb
commented
Jul 2, 2021
| _log.Warning( | ||
| "Serializer not defined for message with serializer id [{0}] and manifest [{1}]. " + | ||
| _log.Warning(error, | ||
| "Deserialization failed for message with serializer id [{0}] and manifest [{1}]. " + |
There was a problem hiding this comment.
Passed in the Exception as a parameter and made it clear that this was a read-side failure, not a write-side failure
This was referenced Aug 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't capturing the exception thrown during deserialization anymore, just logging the error message. A throwback from before Akka.NET v1.4 when only the
ILoggingAdatper.Errormethod acceptedExceptionarguments