make Router open to extension
#5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Marked a handful of key methods as `virtual` * Replaced `TBD` with relevant XML-DOC comments in most areas * Cleaned up outdated code styles * Made `UnWrap` `protected` so it can be used in subclasses
Aaronontheweb
commented
Aug 14, 2021
| @@ -4487,6 +4494,8 @@ namespace Akka.Routing | |||
| public virtual string RouterDispatcher { get; } | |||
| public virtual bool StopRouterWhenAllRouteesRemoved { get; } | |||
| public abstract Akka.Routing.Router CreateRouter(Akka.Actor.ActorSystem system); | |||
| [Akka.Annotations.InternalApiAttribute()] | |||
| public abstract Akka.Actor.ActorBase CreateRouterActor(); | |||
There was a problem hiding this comment.
Had to make this public for a Phobos-specific issue, namely trying to wrap Akka.NET's built-in routers for the purposes of telemetry injection.
Aaronontheweb
commented
Aug 14, 2021
| @@ -94,13 +94,9 @@ internal override Routee NewRoutee(Props routeeProps, IActorContext context) | |||
| .AttachChild(Local.EnrichWithPoolDispatcher(routeeProps, context).WithDeploy(deploy), false, name); | |||
| return new ActorRefRoutee(actorRef); | |||
| } | |||
|
|
|||
| // TODO: why internal? | |||
There was a problem hiding this comment.
Old comment asking a question answered by this PR - why was this marked as internal in the first place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualTBDwith relevant XML-DOC comments in most areasUnWrapprotectedso it can be used in subclasses