Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip racy substream spec #5258

Merged
merged 3 commits into from
Sep 6, 2021
+8 −1
Merged

skip racy substream spec #5258

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a74ae1
skip racy substream spec
Aaronontheweb Sep 6, 2021
c0aa1e9
Merge branch 'dev' into harden/skip-Akka.Streams-GroupBy_and_SplitWhe…
Aaronontheweb Sep 6, 2021
30650ef
Merge branch 'dev' into harden/skip-Akka.Streams-GroupBy_and_SplitWhe…
Aaronontheweb Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/core/Akka.Streams.Tests/Dsl/SubstreamSubscriptionTimeoutSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public SubstreamSubscriptionTimeoutSpec(ITestOutputHelper helper) : base(Config,
Materializer = ActorMaterializer.Create(Sys, settings);
}

[Fact]
[Fact(Skip = "Racy")]
public void GroupBy_and_SplitWhen_must_timeout_and_cancel_substream_publisher_when_no_one_subscribes_to_them_after_some_time()
{
this.AssertAllStagesStopped(() =>
Expand All @@ -57,6 +57,13 @@ public void GroupBy_and_SplitWhen_must_timeout_and_cancel_substream_publisher_wh
publisherProbe.SendNext(1);
publisherProbe.SendNext(2);
publisherProbe.SendNext(3);

/*
* Why this spec is skipped: in the event that subscriber.ExpectSubscription() or (subscriber.ExpectNext()
* + s1SubscriberProbe.ExpectSubscription()) exceeds 300ms, the next call to subscriber.ExpectNext will
* fail. This test is too tightly fitted to the timeout duration to be reliable, although somewhat ironically
* it does validate that the underlying cancellation does work!
*/

var s1 = subscriber.ExpectNext().Item2;
// should not break normal usage
Expand Down