Add backward compatibility to PrimitiveSerializers #5280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Sep 15, 2021
| @@ -78,6 +85,9 @@ public override object FromBinary(byte[] bytes, string manifest) | |||
| /// <inheritdoc /> | |||
| public override string Manifest(object obj) | |||
| { | |||
| if (_useNeutralPrimitives) | |||
| return obj.GetType().TypeQualifiedName(); | |||
There was a problem hiding this comment.
Need to emulate the old serializer behaviour, which is to embed the type name as manifest.
Related code:
https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Remote/MessageSerializer.cs#L62-L74
… github.com:Arkatufus/akka.net into Add_backward_compatibility_for_PrimitiveSerializers
Aaronontheweb
approved these changes
Sep 16, 2021
| { | ||
| var c = RARP.For(Sys).Provider.RemoteSettings.Config.GetConfig("akka.actor.serialization-settings.primitive"); | ||
| c.Should().NotBeNull(); | ||
| c.GetBoolean("use-neutral-primitives").Should().BeFalse(); |
|
|
||
| namespace Akka.Remote.Tests.Serialization | ||
| { | ||
| public class BugFix5279Spec: AkkaSpec |
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
May 2, 2024
Add backward compatibility to PrimitiveSerializers (akkadotnet#5280) * Add backward compatibility to PrimitiveSerializers * Update API Approver list
Aaronontheweb
pushed a commit
that referenced
this pull request
May 2, 2024
* Change the base class of PrimitiveSerializers to SerializerWithStringManifest (#4989) * Change the base class of PrimitiveSerializers to SerializerWithStringManifest * Add backward compatibility to the wire format * Update API Approver list (cherry picked from commit 25246ac) * cherry-picked from 6101fea Add backward compatibility to PrimitiveSerializers (#5280) * Add backward compatibility to PrimitiveSerializers * Update API Approver list * Change PrimitiveSerializer compatibility switch setting name from `use-neutral-primitives` to `use-legacy-behavior` for less ambiguity (#5290) * Change PrimitiveSerializer compatibility switch setting name from `use-neutral-primitives` to `use-legacy-behavior` for less ambiguity * Fix unit test * Change default to full compatibility (on) * Fix unit test Co-authored-by: Aaron Stannard <aaron@petabridge.com> (cherry picked from commit 302e3cb) * Code cleanup * Fix FSharp.Core package problem * Fix CI/CD script - Change vmimage to windows-latest and ubuntu-latest * Fix CI/CD script - Install SDK * Bump net45 target to net452 * Fix CI/CD script * Bump Incrementalist.Cmd to 0.9.0 * Revert "Bump net45 target to net452" This reverts commit 2d0d76d. * Revert "Code cleanup" This reverts commit d72b753. * Code cleanup * Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5279